Sort help args to make them reproducible#3728
Open
jspricke wants to merge 1 commit into
Open
Conversation
get_help_option_names() uses a set which is not ordered. The return value is used by mkdocs-click making the mkdocs-doc package in Debian not reproducible: https://reproduce.debian.net/all/unstable.html#mkdocs-doc
Member
|
I don't think the set or this simple sort are correct. We probably want to apply some specific order, such as long options then short options, or preserve the order they were originally specified. @kdeldycke I think you added this (and maybe I suggested the set in review, can't remember)? What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_help_option_names() uses a set which is not ordered.
The return value is used by mkdocs-click making the
mkdocs-doc package in Debian not reproducible:
https://reproduce.debian.net/all/unstable.html#mkdocs-doc