Improve lexing of unclosed escaped strings#2164
Closed
rubinovitz wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2109.
This avoids running the general string regular expression when the lexer is already positioned at a quoted string inside a block, variable, or line statement. A small scanner finds the closing quote while respecting escaped quotes, or raises the same syntax error path immediately when the string is unterminated.
This keeps the existing regex for compatibility, but skips its backtracking-heavy failure case for unclosed strings with many escape sequences.
Validation:
python -m pytest tests/test_lexnparse.py -q-> 151 passedpython -m pytest -q-> 912 passed