Fixed slice filter adding fill_with to every slice when evenly divisible#2170
Closed
bibekmhj wants to merge 1 commit into
Closed
Fixed slice filter adding fill_with to every slice when evenly divisible#2170bibekmhj wants to merge 1 commit into
bibekmhj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2118.
When the iterable length is evenly divisible by
slices,slices_with_extraworks out to 0, so the conditionslice_number >= slices_with_extrais true for every iteration andfill_withgets appended to every slice.[1,2,3,4]|slice(4, 'foo')ends up as[[1,'foo'], [2,'foo'], [3,'foo'], [4,'foo']]instead of[[1], [2], [3], [4]].Gating on
slices_with_extrabeing non-zero fixes it. Uneven splits behave the same as before. Regression test added next totest_slice.