Automatically create Debian Package and add CI/CD#8
Open
AndrewQuijano wants to merge 3 commits intopanda-re:mainfrom
Open
Automatically create Debian Package and add CI/CD#8AndrewQuijano wants to merge 3 commits intopanda-re:mainfrom
AndrewQuijano wants to merge 3 commits intopanda-re:mainfrom
Conversation
AndrewQuijano
changed the title
Author
|
I also added new CI/CD, unfortunately it looks like ARM hypercalls are broken. i386 - PASS 
x86-64 - PASS 
ARM - FAIL 
AARCH64 - FAIL 
|
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
main
branch
2 times, most recently
from
138c87b to
5fdc2aa
Compare
AndrewQuijano
changed the title
2 tasks
AndrewQuijano
force-pushed
the
main
branch
2 times, most recently
from
60e9d28 to
6d21ef0
Compare
Author
|
Hi @lacraig2, please review the PR, please let me know if you have suggestions for the LibHC Debian package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I believe that, for easier maintenance, as this library is unlikely to be updated frequently, creating a Debian package to install the header would be beneficial.
If there is ever a need for a hot-fix, with everything having a release, someone can use jq to confirm they are using the latest version of libhc.
Plus, I can confirm that creating releases works, https://github.com/AndrewQuijano/libhc/releases/tag/v0.0.2
Here is the content of the files, showing that this packaging works as intended:
Installation works:
This should also close #5 with the fix on the second commit.