Skip to content

✨ feat: Utilize spf13/viper for configs#85

Merged
jpmcb merged 1 commit intomainfrom
viper
Mar 2, 2026
Merged

✨ feat: Utilize spf13/viper for configs#85
jpmcb merged 1 commit intomainfrom
viper

Conversation

@jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Feb 12, 2026

  • ✨ Introduces spf13/viper for config management

Continue Tasks: ✅ 3 no changes — View all

@jpmcb jpmcb changed the title feat: Utilize spf13/viper for configs ✨ feat: Utilize spf13/viper for configs Mar 2, 2026
@jpmcb jpmcb marked this pull request as ready for review March 2, 2026 20:59
Copy link
Contributor

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made an issue to follow up with some docs that may be needed. https://github.com/papercomputeco/tapes.dev/issues/66

@jpmcb jpmcb force-pushed the viper branch 2 times, most recently from b7ee9de to 1b75ad4 Compare March 2, 2026 21:41
Signed-off-by: John McBride <john@papercompute.com>
@jpmcb jpmcb merged commit 94800ae into main Mar 2, 2026
14 checks passed
@jpmcb jpmcb deleted the viper branch March 2, 2026 22:04
@continue
Copy link

continue bot commented Mar 2, 2026

Docs Review

This PR introduces spf13/viper for configuration management. This is a significant change that affects:

  1. New environment variable support - Config now supports TAPES_ prefixed environment variables (e.g., TAPES_PROXY_LISTEN, TAPES_API_LISTEN, TAPES_STORAGE_SQLITE_PATH)
  2. Configuration precedence - New config precedence order: CLI flags > Environment variables > config.toml file > Defaults
  3. New embedding-dimensions flag - The --embedding-dimensions flag is now exposed and configurable

These are user-facing changes that should be documented, but I cannot update the documentation because the papercomputeco/tapes.dev repository doesn't exist or is not accessible. The README references https://tapes.dev/docs but there's no corresponding docs repository I can find.

Recommendation: Once the docs repository is available, add documentation for:

  • Environment variable configuration (TAPES_PROXY_LISTEN, TAPES_API_LISTEN, etc.)
  • The configuration precedence chain (flag > env > file > default)
  • The new embedding.dimensions config option

PR #85 was merged: ✨ feat: Utilize spf13/viper for configs
PR URL: #85
Merged by: jpmcb

Generated with Continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants