Open
Conversation
We added an async support for the request method by creating an async_request method. It provides the same arguments as the other one. In order to support async calls, we used the aiohttp module. We didn't change the way the method works but just changed sync calls by async calls. It concerns api calls and sleep.
theanaverwaerde
approved these changes
Aug 22, 2024
Added missing ssl verification. Convert data to be FormData. Added auth by using BasicAuth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added an async support for the request method from the class QGConnector
method by creating an async_request method.
The async_request provides the same arguments as the other one.
In order to support async calls, we used the aiohttp module. We didn't change the way the method works but just changed sync calls by async calls. It concerns api calls and sleep.
We didn't use the normal syntax of context managers because it would have been problematic because of different try...excepts in the method. Instead of this, we used the aenter() and aexit() dunder methods.
This Pull request makes sense if we have to perform several api calls. Instead of waiting each one to be finished, we can use the advantage of concurrency to speed those up.