fix: review follow-ups from the embeddable-cli change#4
Merged
Conversation
Stamp VersionNumber from the release tag instead of a hardcoded literal that drifts, inline the pass-through mount wrapper, gofmt the tree, and gate CI on gofmt so it stays clean. Claude-Session: https://claude.ai/code/session_0191kNQ9ZxzwEng9QfcfBKe6
giraffesyo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses the confirmed follow-ups from the review of #3 (tracked in parallelworks/core#17051):
cli.Runno longer hardcodesVersionNumber; release builds stampinternal.VersionNumberfrom the tag (${GITHUB_REF_NAME#v}), with a0.0.0-devfallback for untagged builds. Verified: a build stamped with9.9.9reportsgoofys version 9.9.9-v9.9.9.mount()pass-through wrapper at its single call site.gofmt -wacross the tree (utils.go plus three other pre-existing dirty files) and a gofmt gate added to ci.yml so it stays clean.MemAvailablefrom /proc/meminfo (kernel 3.14+) with the samecalcAvailVmem/Cached+Freefallbacks, somaxMemToUsebehaves identically. No code change needed.Testing
go build ./...(darwin + linux/amd64 CGO=0),go test ./api/..., gofmt clean, and the ldflags version stamp verified end to end.https://claude.ai/code/session_0191kNQ9ZxzwEng9QfcfBKe6