This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-im-online to pallet attribute macro.#8714
Merged
4 commits merged intoparitytech:masterfrom May 5, 2021
Merged
Conversation
gui1117
added
A0-please_review
gui1117
approved these changes
May 3, 2021
Contributor
There was a problem hiding this comment.
the test change is wrong, INVALID_VALIDATORS_LEN is matching for a specific value.
and the metadata changed, in general you should compare the metadata before and after the changes to see if storages and types are upgraded correctly.
(both should be fixed by the commits below)
But apart from that it is good to me
shawntabrizi
approved these changes
May 5, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* Migrate pallet-im-online to pallet attribute macro. * Move validate_unsigned into pallet macro. * fix metadata * fix test Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Converts the
ImOnlinepallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
ImOnlinepallet must be careful about the name they used inconstruct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of theImOnlinepallet.