This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-scheduler to pallet attribute macro #8769
Merged
10 commits merged intoparitytech:masterfrom May 18, 2021
Merged
Conversation
gui1117
approved these changes
May 12, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
the calls function should stay private, but otherwise it is good to me
Also in general I prefer not to format untouched code, that make review more easy.
Polkadot/Kusama/Westend correctly have Scheduler as pallet name so no migration needed
gui1117
added
A0-please_review
Contributor
Author
|
Sorry about the unwanted formatting, I ran cargo fmt and didn't notice the unrelated changes. Reverted most of it |
KiChjang
suggested changes
May 15, 2021
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
The metadata for events needs to be added, others are documentation and whitespace changes.
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
KiChjang
reviewed
May 15, 2021
KiChjang
approved these changes
May 18, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
11 tasks
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* migrate to pallet! * fixes * fix genesis * code review fixes * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * fix metadata Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Converts the
Schedulerpallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.