Migrate pallet-session and session-historical to pallet attribute macro#8815
Migrate pallet-session and session-historical to pallet attribute macro#8815stanly-johnson wants to merge 9 commits intoparitytech:masterfrom
Conversation
|
@stanly-johnson Please use tabs in the modified files per our coding standards. Thanks! |
KiChjang
left a comment
There was a problem hiding this comment.
Migration looks good, but I can still see spaces with some of these files.
|
| } | ||
|
|
||
| decl_storage! { | ||
| trait Store for Module<T: Config> as Session { |
There was a problem hiding this comment.
This is a breaking change. The historical pallet will no longer use the Session storage.
This needs a storage migration.
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still needs a storage migration |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Part of #7882.
Converts the
sessionandsession-historicalpallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.