Conversation
gilescope
added
A0-please_review
expenses
left a comment
expenses
left a comment
There was a problem hiding this comment.
I think this looks good, I haven't checked over the executor code to see if it matches though.
Co-authored-by: Ashley <ashley.ruglys@gmail.com>
|
Great build error: |
|
|
||
| //! A set of common definitions that are needed for defining execution engines. | ||
|
|
||
| #![doc = include_str!("../README.md")] |
There was a problem hiding this comment.
Can you please move the docs back here.
There was a problem hiding this comment.
Ok, I can see I'm too early somehow for this change. Will do.
There was a problem hiding this comment.
We also don't use this anywhere and I'm not sure that stuff like intra doc links would still work. I honestly would not loose such a good feature for having an external file that some editor can understand better.
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
3 participants
No code changes.
Removed duplication between module docs and readme.md. Apparently this is the 'right' way to do it these days.
Please dive in with any suggestions on how we can re-word the docs to make anything clearer.
(And also if I've misunderstood anything and am twisting the original docs meaning)