chore(ci): Remove prettier quoted argument to fix issue on Windows#7489
chore(ci): Remove prettier quoted argument to fix issue on Windows#7489mtrezza merged 2 commits intoparse-community:masterfrom
Conversation
|
Do we need any quotes at all? In your comment you wrote that removing the quotes fixed the issue for windows. If it also works for Unix we can just remove then. |
8353b9f to
e2abccd
Compare
|
@mtrezza Ahah, yes, reading back my old comments 😆 ✅ Fixed |
|
This likely applies to the example repo too |
|
Well spotted, could someone open a PR there if necessary? |
Codecov Report
@@ Coverage Diff @@
## master #7489 +/- ##
==========================================
- Coverage 93.96% 93.93% -0.04%
==========================================
Files 181 181
Lines 13271 13271
==========================================
- Hits 12470 12466 -4
- Misses 801 805 +4
Continue to review full report at Codecov.
|
|
I just notice that it says "This branch is out-of-date with the base branch". Can you rebase? |
|
@mtrezza Updated |
|
Merged - thanks for this PR! |
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Windows doesn't like single quotes around prettier arguments.
Related issue: #7419 (comment)
Approach
TODOs before merging