fix: exclude localparams from parameter overrides#218
Draft
hongjr03 wants to merge 1 commit into
Draft
Conversation
|
Docs preview: https://vide.pascal-lab.net/preview/pr-218/ |
Member
Author
|
Keeping this in draft while I revisit the parameter classification. The current HIR model handles explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change models parameter declarations in HIR as either
parameterorlocalparam, including keyword inheritance in module parameter port lists.Code actions and completion now use the HIR overridability model instead of treating all parameter declarations as instance-override candidates. This prevents
Fill parametersfrom adding module-locallocalparamentries such as memory operation constants.Validation
cargo fmt --checkcargo test -p ide code_action::testscargo test -p ide completion::enginecargo test code_action_request_