refactor(build): unify VS Code packaging and release profiles#240
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the size of vide release binaries by tightening Rust release build settings and making Chrome/Perfetto profiling trace support opt-in via a Cargo feature, while preserving incremental compilation for non-tag builds.
Changes:
- Enable Thin LTO and set
codegen-units = 1for the defaultreleaseprofile to improve binary size. - Make
tracing-chromeoptional and gate profile trace setup behind a newprofile-tracefeature, with a clear runtime error when profiling is requested without the feature. - In release CI, disable
releaseincremental compilation only for tag-based (v*) pushes, including for the manylinux docker build.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main.rs |
Gates profile tracing behind profile-trace and returns a helpful error when requested without the feature. |
Cargo.toml |
Makes tracing-chrome optional, adds profile-trace feature, and enables Thin LTO + codegen-units=1 in release. |
.github/workflows/release.yml |
Disables release incremental builds only for tag push releases and passes the env override into the manylinux docker build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roife
force-pushed
the
perf/optimize-bin-size
branch
from
c614d97 to
261a26f
Compare
|
Docs preview: https://vide.pascal-lab.net/preview/pr-240/ |
…rt for `struct`s in document symbols (#239)
# Conflicts: # src/main.rs
hongjr03
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change unifies the VS Code extension packaging flow around focused packaging modules and
cargo xtaskserver preparation, while keeping release binaries smaller by enabling release size optimizations and making profile tracing an opt-in feature that is only packaged for debug/profile builds.