chore: migrate from setup.py to pyproject.toml#144
Conversation
ctran88
force-pushed
the
PSG-4874-update-build-system
branch
3 times, most recently
from
6ca69d4 to
79715a7
Compare
| - name: Install dependencies | ||
| if: ${{ steps.release.outputs.release_created }} | ||
| run: | | ||
| python -m pip install --upgrade pip |
There was a problem hiding this comment.
doesn't seem necessary to try to upgrade pip just to install build
| python setup.py pytest | ||
| ``` | ||
|
|
||
| ### Publish the package |
There was a problem hiding this comment.
people outside the org can't publish anyways, so removing this block
| ] | ||
| description = "Passkey Complete for Python - Integrate into your Python API or service to enable a completely passwordless standalone auth solution with Passage by 1Password" | ||
| readme = "README.md" | ||
| classifiers = [ |
There was a problem hiding this comment.
these were pulled from https://pypi.org/classifiers/
| "Bug Tracker" = "https://github.com/passageidentity/.github/blob/main/SUPPORT.md" | ||
|
|
||
| [project.license] | ||
| file = "LICENSE" |
There was a problem hiding this comment.
[project]
license-files = ["LICENSE"]the above syntax is noted in the docs but hasn't been adopted by setuptools yet, so we are using the legacy syntax for now
pyproject.toml
Outdated
| [tool.setuptools.packages.find] | ||
| where = ["passageidentity"] |
There was a problem hiding this comment.
this should take care of the packages and package_dir blocks from the old setup.py:
Lines 38 to 51 in f359061
ctran88
force-pushed
the
PSG-4874-update-build-system
branch
2 times, most recently
from
a38885e to
46a7024
Compare
ctran88
force-pushed
the
PSG-4874-update-build-system
branch
from
46a7024 to
60c4cdb
Compare
|
| packages=[ | ||
| "passageidentity", | ||
| "passageidentity.models", | ||
| "passageidentity.openapi_client", | ||
| "passageidentity.openapi_client.api", | ||
| "passageidentity.openapi_client.models", | ||
| ], | ||
| package_dir={ | ||
| "passageidentity": "passageidentity", | ||
| "passageidentity.models": "passageidentity/models", | ||
| "passageidentity.openapi_client": "passageidentity/openapi_client", | ||
| "passageidentity.openapi_client.api": "passageidentity/openapi_client/api", | ||
| "passageidentity.openapi_client.models": "passageidentity/openapi_client/models", | ||
| }, |
There was a problem hiding this comment.
manually specifying these is no longer necessary with automatic discovery
i inspected the build artifact and it included everything from the root passageidentity folder and did not include the tests folder
2 participants
What's New?
used these refs when writing the toml:
Screenshots (if appropriate):
Type of change
Checklist:
Additional context