Skip to content

🛡️ Sentinel: [CRITICAL/HIGH] Fix File Upload Extension Validation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xb1g wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL/HIGH] Fix File Upload Extension Validation #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions lib/constants/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ export const ALLOWED_IMAGE_TYPES = new Set([
"image/heif",
]);

export const ALLOWED_DOCUMENT_TYPES = new Set([
"application/pdf",
]);
export const ALLOWED_DOCUMENT_TYPES = new Set(["application/pdf"]);

export const ALLOWED_GENERAL_TYPES = new Set([
"application/pdf",
Expand All @@ -48,6 +46,7 @@ export const ALLOWED_GENERAL_TYPES = new Set([

// Dangerous file extensions to block
export const DANGEROUS_EXTENSIONS = [
// Executables
".exe",
".bat",
".cmd",
Expand All @@ -58,6 +57,17 @@ export const DANGEROUS_EXTENSIONS = [
".app",
".deb",
".rpm",
// Scripts
".php",
".sh",
".py",
".pl",
".cgi",
// Web Content
".html",
".htm",
".svg",
".xml",
];

// Upload configuration
Expand All @@ -70,7 +80,7 @@ export const CHUNK_SIZE = 5 * 1024 * 1024; // 5MB chunks for resumable uploads
*/
export function validateFileSize(
fileSize: number,
maxSize: number
maxSize: number,
): { valid: boolean; error?: string } {
if (fileSize === 0) {
return { valid: false, error: "File is empty" };
Expand All @@ -89,9 +99,10 @@ export function validateFileSize(
/**
* Validate file name
*/
export function validateFileName(
fileName: string
): { valid: boolean; error?: string } {
export function validateFileName(fileName: string): {
valid: boolean;
error?: string;
} {
if (!fileName || fileName.trim().length === 0) {
Comment on lines +102 to 106
return { valid: false, error: "File name is required" };
}
Expand All @@ -117,7 +128,7 @@ export function validateFileName(
*/
export function validateMimeType(
mimeType: string,
allowedTypes: Set<string>
allowedTypes: Set<string>,
): { valid: boolean; error?: string } {
if (!mimeType) {
return { valid: false, error: "File type is required" };
Expand All @@ -141,7 +152,7 @@ export function validateFile(
fileSize: number,
mimeType: string,
allowedTypes: Set<string>,
maxSize: number
maxSize: number,
): { valid: boolean; error?: string } {
// Validate file name
const nameValidation = validateFileName(fileName);
Expand Down