Skip to content

⚡ Bolt: [performance improvement] Optimize array filtering with Set lookups#147

Open
xb1g wants to merge 1 commit into
mainfrom
bolt-optimize-array-includes-3984100059902385752
Open

⚡ Bolt: [performance improvement] Optimize array filtering with Set lookups#147
xb1g wants to merge 1 commit into
mainfrom
bolt-optimize-array-includes-3984100059902385752

Conversation

@xb1g

@xb1g xb1g commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

💡 What: Replaced O(N*M) array .includes() calls inside .filter() loops with pre-computed O(1) Set lookups in grading and assignments API routes.
🎯 Why: To eliminate nested O(N^2) complexity bottlenecks when processing arrays, dramatically improving execution speed for large datasets (like classrooms with many students and assignments).
📊 Impact: Reduces lookup complexity from O(N) to O(1) per iteration, leading to significant latency reduction when filtering missing users or nodes in large cohorts.
🔬 Measurement: Verify by benchmarking response times of the /api/classrooms/[id]/grading and /api/assignments/[id]/nodes routes under heavy load with large classroomMembers and submissionUserIds arrays.


PR created automatically by Jules for task 3984100059902385752 started by @xb1g

Co-authored-by: xb1g <70068561+xb1g@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pseed Error Error Mar 24, 2026 3:49am

Request Review

Copilot AI review requested due to automatic review settings May 11, 2026 17:28
@xb1g
xb1g force-pushed the bolt-optimize-array-includes-3984100059902385752 branch from 34e777c to e124996 Compare May 11, 2026 17:28
@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Unable to deploy a commit from a private repository on your GitHub organization to the wachaa1319's projects team on Vercel, which is currently on the Hobby plan. In order to deploy, you can:

  • Make your repository public or
  • Upgrade to Pro. A Pro subscription is required to deploy from a private organization repository.

To read more about collaboration on Vercel, click here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes two Next.js API routes by replacing repeated Array.includes() membership checks inside .filter() loops with precomputed Set lookups, reducing worst-case lookup cost when processing large classrooms/assignments.

Changes:

  • In /api/classrooms/[id]/grading, precomputes a Set of submissionUserIds and uses .has() to find classroom members missing from submissions.
  • In /api/assignments/[id]/nodes, precomputes a Set of existingNodeIds and uses .has() to find missing node IDs before inserting assignment nodes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/api/classrooms/[id]/grading/route.ts Uses a Set for membership checks when computing missingUserIds to avoid repeated linear .includes() lookups.
app/api/assignments/[id]/nodes/route.ts Uses a Set for membership checks when computing missingNodes to avoid repeated linear .includes() lookups.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
web 993d271 May 11 2026, 06:32 PM

@xb1g
xb1g force-pushed the bolt-optimize-array-includes-3984100059902385752 branch 2 times, most recently from 0649a63 to 993d271 Compare May 11, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants