Added scroll functionality to sidebar tsd-nested-navigation#19
Open
qublaidev wants to merge 1 commit intopastelsky:mainfrom
Open
Added scroll functionality to sidebar tsd-nested-navigation#19qublaidev wants to merge 1 commit intopastelsky:mainfrom
qublaidev wants to merge 1 commit intopastelsky:mainfrom
Conversation
Owner
|
This might get awkward because you now possibly have an inner scroll as well as an external sidebar scroll. |
Author
Yes, that's why I created a little spacing between scroll area of the accordion content and sidebar. I can add a seperate scrollbar to the sidebar to make the user understand the difference a bit better but I'm afraid that it would make it seem cluttered and also I couldn't find the tsd-small-nested-navigation :dD |
Owner
|
Yeah I don’t think that’s a very conventional way for sidebars to work (I
haven’t seen dual scrolls in use anywhere personally or found them useful).
I think search might be better suited for longer lists. We do want to add a
CMD + K search pallete to tsdocs for quick nav, so it might be more
appropriate to focus energy there.
Regards,
Shubham Kanodia
…On Thu, 21 Dec 2023 at 11:51 AM, Kubilay Kabataş ***@***.***> wrote:
This might get awkward because you now possibly have an inner scroll as
well as an external sidebar scroll.
Yes, that's why I created a little spacing between scroll area of the
accordion content and sidebar.
I can add a seperate scrollbar to the sidebar to make the user understand
the difference a bit better but I'm afraid that it would make it seem
cluttered and also I couldn't find the tsd-small-nested-navigation :dD
—
Reply to this email directly, view it on GitHub
<#19 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEIEH6H4KP4WUDBZG7WHLDYKPINLAVCNFSM6AAAAABA466ZNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGU4DKNRVGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2023-12-20.18-00-23.mp4
QOL improvement: for when there is too much functions, interfaces etc. to scroll to top of the sidebar