feat(cache): add device-detector cache option to improve performance#19
Merged
pataar merged 3 commits intoMay 6, 2026
Merged
Conversation
pataar
reviewed
May 5, 2026
pataar
reviewed
May 5, 2026
Owner
|
CI is failing |
Author
|
I believe the issue was |
Owner
|
Thanks, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Summary
Adds an opt-in
cache.device-detectorconfig option (defaultfalse) that enables thematomo/device-detectorengine's own internal cache via Laravel's cache store. The default isfalse, so there is no behavior change for existing installs.Requires a Laravel application context. Do not enable in standalone mode —
\DeviceDetector\Cache\LaravelCacheuses theCachefacade and will throw without a bootstrapped app.Checklist
composer testpassescomposer analysepasses (PHPStan level max, zero errors)Test plan
test_invoke_with_device_detector_cache_enabledtoDeviceDetectorTestCache::spy()to assert thatLaravelCacheactually called through to Laravel's cache store