Open
Conversation
added 16 commits
September 18, 2022 13:10
asimbhdr96
reviewed
Sep 26, 2022
Collaborator
asimbhdr96
left a comment
asimbhdr96
left a comment
There was a problem hiding this comment.
in your storybook please add different colors also for the default switch make the circular toggle different color than the slider both are gray maybe for the default one use white color slider gray
| //in controlled component, the input’s(switch) value is always driven by the React state. | ||
|
|
||
| const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| // setShowOn((prev) => !prev); |
Collaborator
There was a problem hiding this comment.
remove unnecessary code
| expect(checkbox).not.toBeChecked(); | ||
| fireEvent.click(checkbox); | ||
| expect(checkbox).toBeChecked(); | ||
| // expect(checkbox).toHaveAttribute('checked', 'true'); |
| margin-left: $margin-l; | ||
| margin-top: $margin-r; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
put those mixins into the general mixin file
| @@ -0,0 +1,4 @@ | |||
| $switch-primary: rgba(32, 201, 151, 0.8); | |||
| $switch-secondary: rgba(108, 117, 125, 0.8); | |||
| $switch-primary-hover: 0 0 0 3px rgba(32, 201, 151, 0.2); | |||
Collaborator
There was a problem hiding this comment.
also put them into the general variables file
| @import '../components/Card/Card'; | ||
| @import '../components/Progress/Progress'; | ||
|
|
||
| //Switch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUI-6 Switch Component