fix: prevent subtitle truncation in banner, hud, and alert#2
Merged
Conversation
Long subtitles were getting cut off / ellipsized instead of wrapping. Apply `.lineLimit(nil)` + `.fixedSize(horizontal: false, vertical: true)` to the subtitle Text in all three layouts (banner, hud, alert) so they wrap to as many lines as needed. Extends the original fix from arslankaleem7229 (elai950#106), which only covered the banner layout, to hud and alert as well. Fixes long-subtitle truncation reported in elai950#61, elai950#67. Co-Authored-By: arslankaleem7229 <arslankaleem7229@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.lineLimit(nil)+.fixedSize(horizontal: false, vertical: true)to the subtitleTextin all three layouts — banner, hud, and alert — so long subtitles wrap instead of being truncated with….Why
Long subtitles were ellipsized. Reported upstream in elai950#61 and elai950#67.
Credit
Based on @arslankaleem7229's PR elai950#106, which only patched the banner layout. This extends the same fix to hud and alert for consistency.
Verification
swift buildpasses.🤖 Generated with Claude Code