feat(PF-4339,PF-4346,PF-4343): add scanner skill evals#133
Conversation
Regenerated PLUGINS.md, updated skill count badge (31 → 32), added pf-react-breaking-changes to CONTRIBUTING-SKILLS.md migration table, and fixed bullet formatting in migration plugin README.
Add eval configs and test cases for three scanner skills: - pf-raw-colors-scan: raw hex/rgb/hsl detection, token suggestions, false-positive control - pf-import-checker: PF6 import path validation (charts, chatbot), negative control - pf-class-migration-scanner: legacy class/token detection, PF6 replacements, confidence
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (35)
📝 WalkthroughWalkthroughAdds three new evaluation suites (pf-class-migration-scanner, pf-import-checker, pf-raw-colors-scan) under eval/, each with test fixtures (TSX/SCSS), annotations.yaml, input.yaml, and eval.yaml judge configurations. Also updates documentation: README.md skills badge count, PLUGINS.md and plugin README descriptions, and CONTRIBUTING-SKILLS.md plugin table. ChangesEvaluation Suites
Documentation Updates
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Summary - Add eval configs and test cases for 3 scanner skills (Batch 1 of PF-4230 eval coverage plan) - **pf-raw-colors-scan**: 3 cases — raw hex/rgb/hsl detection, token declaration exception, already-tokenized negative control - **pf-import-checker**: 3 cases — invalid charts import, invalid chatbot import, valid PF6 imports negative control - **pf-class-migration-scanner**: 3 cases — legacy versioned classes, legacy token patterns, valid PF6 code negative control - All judges use deterministic `check` type (Python regex/string matching) - Negative-control judges check for absence of violation markers (Kent's testing feedback applied) Closes: PF-4339 Closes: PF-4346 Closes: PF-4343
Summary
checktype (Python regex/string matching)Closes: PF-4339
Closes: PF-4346
Closes: PF-4343
Summary by CodeRabbit
New Features
Documentation
Bug Fixes