Skip to content

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon#12513

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-times-circle-icon-with-rh-ui-close-circle-fill
Open

fix(TimesCircleIcon): Replace TimesCircleIcon with RhUiCloseCircleFillIcon#12513
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-times-circle-icon-with-rh-ui-close-circle-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated status indicator and warning/error icons across file upload components and Primary Detail demos. The “danger” and related warning/error states now use the close-circle filled icon instead of the previous times-circle icon, aligning visuals with the design system for more consistent UI feedback.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 49185be5-0582-4804-b5de-c41893f6e58d

📥 Commits

Reviewing files that changed from the base of the PR and between af9ef3e and 3ff492c.

📒 Files selected for processing (5)
  • packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
✅ Files skipped from review due to trivial changes (3)
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx

Walkthrough

TimesCircleIcon is replaced with RhUiCloseCircleFillIcon in MultipleFileUploadStatus and in the PrimaryDetail demo markdown and example components.

Changes

Icon replacement across component and demos

Layer / File(s) Summary
MultipleFileUploadStatus danger icon update
packages/react-core/src/components/MultipleFileUpload/MultipleFileUploadStatus.tsx
Import switched from TimesCircleIcon to RhUiCloseCircleFillIcon; the statusToggleIcon === 'danger' branch now sets the new icon.
PrimaryDetail demo variants icon update
packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx, packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
Icon imports and the affected DataList rows are updated to render RhUiCloseCircleFillIcon instead of TimesCircleIcon.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: thatblindgeye, kmcfaul, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: replacing TimesCircleIcon with RhUiCloseCircleFillIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 23, 2026 21:02
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:16
…lIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-times-circle-icon-with-rh-ui-close-circle-fill branch from af9ef3e to 3ff492c Compare July 8, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants