Skip to content

fix(Wizard): add useEffect import#12538

Open
LightOfHeaven1994 wants to merge 1 commit into
patternfly:mainfrom
LightOfHeaven1994:fix-wizard-use-effect-import
Open

fix(Wizard): add useEffect import#12538
LightOfHeaven1994 wants to merge 1 commit into
patternfly:mainfrom
LightOfHeaven1994:fix-wizard-use-effect-import

Conversation

@LightOfHeaven1994

@LightOfHeaven1994 LightOfHeaven1994 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What:

  1. Fix for Wizard Progress after submission so it doesn't fail on useEffect https://www.patternfly.org/components/wizard#progress-after-submission
  2. Fix for deprecated Wizard Finish so it doesn't fail on not-imported layout https://www.patternfly.org/components/wizard/react-deprecated/#finished

Closes #12537

Summary by CodeRabbit

  • Documentation
    • Updated the Wizard example documentation to include additional icon and layout resources for richer example rendering.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7a1450f-172a-4bd4-887d-9616901331ea

📥 Commits

Reviewing files that changed from the base of the PR and between a289531 and 00b118c.

📒 Files selected for processing (1)
  • packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md

Walkthrough

This change adds two missing import statements—CogsIcon and layout (Bullseye)—to the deprecated Wizard component's example Markdown documentation, addressing a runtime error caused by missing imports in the example code.

Changes

Wizard Documentation Fix

Layer / File(s) Summary
Fix example imports
packages/react-core/src/deprecated/components/Wizard/examples/Wizard.md
Adds CogsIcon and layout (Bullseye) imports to the deprecated Wizard example documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main Wizard fix and matches the PR's import-related scope.
Linked Issues check ✅ Passed The changes target the reported Wizard example failures by adding the missing example imports.
Out of Scope Changes check ✅ Passed The PR stays within the Wizard documentation example import fixes and adds no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the fix-wizard-use-effect-import branch from 7f8854f to a289531 Compare July 7, 2026 11:24

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just resolve the merge conflicts? The non-deprecated MD file was updated already in another PR, but the deprecated MD file will still need the layout import you added here.

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the fix-wizard-use-effect-import branch from a289531 to 00b118c Compare July 8, 2026 13:43
@LightOfHeaven1994

Copy link
Copy Markdown
Contributor Author

@thatblindgeye sure! done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - [Component] - [short description]

2 participants