Fix cumulative fast-drift in tick scheduler#130
Open
louietyj wants to merge 1 commit into
Open
Conversation
`(60000 / tempo) / subdivisions` integer-divides twice, so each accumulator step drops a fractional ms and the metronome runs progressively fast — e.g. 140bpm with triplets is ~0.6% fast (~22s per hour), audible against a reference click within a minute. Tempos and subdivisions whose intervals divide 60000 cleanly (60, 100, 120 plain, 200 plain, etc.) are unaffected. Switches `nextScheduleTime` to `double` and casts back to `long` only at `postDelayed`. `getInterval()` stays `long` so count-in / timer / UI math is unchanged.
Owner
|
Thank you for your contribution! I will look into it in about one week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(60000 / tempo) / subdivisionsinteger-divides twice, so each accumulator step drops a fractional ms and the metronome runs progressively fast -- e.g. 140bpm with triplets is ~0.6% fast (~22s per hour), audible against a reference click within a minute. Tempos and subdivisions whose intervals divide 60000 cleanly (60, 100, 120 plain, 200 plain, etc.) are unaffected.Switches
nextScheduleTimetodoubleand casts back tolongonly atpostDelayed.getInterval()stayslongso count-in / timer / UI math is unchanged.