Merged
Conversation
fractalbeauty
force-pushed
the
hazel/api33-back-gesture
branch
from
ec5049a to
71ea4bf
Compare
Contributor
|
@paufau can you approve that? <3 |
Owner
|
Thanks for raising the PR and sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes back gesture handling on Android 13+, which introduced new back gesture APIs. We were experiencing a bug where using the back gesture visually closed by modal, but there was still an element covering the screen and blocking interaction. This was likely because the back gesture caused the native dialog to be dismissed, but didn't notify JS to properly handle it.
Closes #66
Changes
Testing
Applying this patch fixed the issue in our app.