ci: shellcheck + bash -n for upstream-drift script#110
Merged
Conversation
Why: the drift script is load-bearing for the weekly upstream sync; catch syntax slips and shell antipatterns before they run on the cron. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Why: review-all flagged ci.yml lacked an explicit permissions: block (token inherited repo default) and that `task ci` skipped lint:shell. Both are one-liners. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint:shellTaskfile target runningbash -n+shellcheckonscripts/upstream-drift.sh.lint-shelljob to the CI workflow so the check runs on every PR.The drift script drives the Monday cron that opens upstream sync PRs. Catching shell slips here keeps that pipeline from no-op'ing silently a week after a regression lands.
Test plan
task lint:shellpasses locallylint-shellCI job is green on this PR