Skip to content

nix: separate flake checks for prop and unit test coverage #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nothingmuch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nix: separate flake checks for prop and unit test coverage #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions nix/checks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,17 @@
) profiles
) toolchains;

checks = testChecks // {
build = toolchains.nightly.buildPackage (checkArgs // { cargoArtifacts = cargoArtifactsRelease; });

coverage = toolchains.nightly.mkCargoDerivation (
mkCoverage =
suffix: features:
toolchains.nightly.mkCargoDerivation (
checkArgs
// {
cargoArtifacts = cargoArtifactsDev;
pnameSuffix = "-coverage";
pnameSuffix = "-coverage${suffix}";
nativeBuildInputs = [ pkgs.cargo-llvm-cov ];
buildPhaseCargoCommand = ''
mkdir -p $out
cargo llvm-cov --all-features --lcov --output-path $out/coverage.lcov || {
cargo llvm-cov --no-default-features --features ${features} --lcov --output-path $out/coverage.lcov || {
# no coverage data when there are no tests yet
if [ ! -s $out/coverage.lcov ]; then
echo "no coverage data (no tests), skipping assertion"
Expand All @@ -71,6 +70,13 @@
}
);

checks = testChecks // {
build = toolchains.nightly.buildPackage (commonArgs // { cargoArtifacts = cargoArtifactsRelease; });

@arminsabouri arminsabouri Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed from checkArgs to commonArgs. Is that intentional?


coverage = mkCoverage "" "unit-tests,prop-tests";
coverage-no-unit-tests = mkCoverage "-no-unit-tests" "prop-tests";
coverage-no-prop-tests = mkCoverage "-no-prop-tests" "unit-tests";

clippy = toolchains.nightly.cargoClippy (
checkArgs
// {
Expand Down
Loading