fix(ui): relationship filter duplicate options when switching operators#16029
Open
howwohmm wants to merge 3 commits intopayloadcms:mainfrom
Open
fix(ui): relationship filter duplicate options when switching operators#16029howwohmm wants to merge 3 commits intopayloadcms:mainfrom
howwohmm wants to merge 3 commits intopayloadcms:mainfrom
Conversation
The `reduceToIDs` helper in the relationship filter's optionsReducer read `option.id`, but options are created with `value` (not `id`). This meant deduplication never worked — `loadedIDs` was always an array of `undefined` values. When switching from `equals` to `is_in`, the second useEffect called `addOptionByID` for the already-loaded value, and because dedup was broken the same option was appended again. Fix: read `option.value` instead of `option.id` so existing options are correctly recognised and skipped. Fixes payloadcms#15947 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
howwohmm
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
good catch @themavik — pushed a fix to use |
Contributor
|
@howwohmm I think we should add an e2e test that fails without this fix and then passes when this fix is implemented. Can you do this? |
Tests verify that ADD correctly deduplicates options by value — both for
single-relation flat lists and multi-relation grouped options.
The dedup test would fail with the original `option.id` read (always
undefined on `{ label, value }` options) and passes with `option.value ?? option.id`.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
added a vitest unit test in
the dedup test fails with the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equalstois in)reduceToIDsinoptionsReducer.tsreadoption.id, but options are created with{ label, value }— there is noidproperty. This meant deduplication never worked:loadedIDswas always[undefined, undefined, ...], soindexOf(doc.id)always returned-1.option.idtooption.valueinreduceToIDsso existing options are correctly recognised and skipped.Fixes #15947
Test plan
equalsoperator and pick a valueis inhasMultipleRelations(polymorphic relationship) to verify grouped options also deduplicate correctly🤖 Generated with Claude Code