fix(plugin-nested-docs): await populateBreadcrumbs in resaveChildren hook#16036
Open
KibbeWater wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(plugin-nested-docs): await populateBreadcrumbs in resaveChildren hook#16036KibbeWater wants to merge 1 commit intopayloadcms:mainfrom
KibbeWater wants to merge 1 commit intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add missing await before populateBreadcrumbs() in the resaveChildren afterChange hook of @payloadcms/plugin-nested-docs.
Why?
populateBreadcrumbs() is an async function, but it was called without await in resaveChildren. This means a Promise object was passed as the data argument to payload.update() instead of the resolved breadcrumb data. In environments with strict transaction isolation, the resulting internal failure can call killTransaction(req) on the shared transaction, silently rolling back the parent document's publish. The catch block only surfaces validation errors, so the rollback goes unnoticed by the user.
In the current codebase, the populateBreadcrumbsBeforeChange hook masks the issue by independently re-fetching parent data during the child update. However, this is an accidental safety net — the resolved data from resaveChildren is still silently discarded and replaced with an unresolved Promise.
How?