fix(ui): use i18n for live preview "Open in new window" tooltip#16038
Open
ruben-hutter wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): use i18n for live preview "Open in new window" tooltip#16038ruben-hutter wants to merge 1 commit intopayloadcms:mainfrom
ruben-hutter wants to merge 1 commit intopayloadcms:mainfrom
Conversation
The "Open in new window" title attribute in the live preview toolbar was hardcoded in English. Replace it with the existing `openInNewTab` translation key, which is already translated in all 44 supported languages.
ruben-hutter
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Author
|
Note: I used the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Open in new window" title attribute in the live preview toolbar was hardcoded in English. Replace it with the existing
openInNewTabtranslation key, which is already translated in all 44 supported languages.