fix(ui): prevent duplicate options in relationship filter dropdown#16042
Open
salahqasm wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): prevent duplicate options in relationship filter dropdown#16042salahqasm wants to merge 1 commit intopayloadcms:mainfrom
salahqasm wants to merge 1 commit intopayloadcms:mainfrom
Conversation
salahqasm
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix duplicate options appearing in the relationship filter dropdown (WhereBuilder) when a value is already selected and the dropdown is reopened — specifically when using condition operator "equals".
Why?
optionsReducerusedoption.idfor deduplication, but options are shaped as { label , value } where the value is the id.How?
changed
optionsReducerfromoption.idtooption.valueBefore:
https://github.com/user-attachments/assets/8442e8f5-b37b-4354-95cd-89152a934e2d
After:
https://github.com/user-attachments/assets/b5a88151-284e-4a0b-9532-2ca10d0919e8