fix(db-mongodb): update mongoose-paginate-v2 to fix collation pagination#16049
Open
JarrodMFlesch wants to merge 4 commits intomainfrom
Open
fix(db-mongodb): update mongoose-paginate-v2 to fix collation pagination#16049JarrodMFlesch wants to merge 4 commits intomainfrom
JarrodMFlesch wants to merge 4 commits intomainfrom
Conversation
When using MongoDB collation with sessions in transactions, mongoose-paginate-v2 chains `.collation()` which breaks session context in mongoose 8.x, causing incorrect totalDocs counts. Changes: - Add custom count function when collation is enabled to pass collation as an option instead of chaining - Use config.localization.defaultLocale for collation locale fallback instead of hardcoded 'en' - Add collation support to count functions Upstream fix submitted: aravindnc/mongoose-paginate-v2#240 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Upgrades mongoose-paginate-v2 from 1.8.5 to 1.9.4 which includes fixes for: - Collation + session in transactions breaking session context - limit in options.options being passed to countDocuments, causing incorrect totalDocs Removes workaround code that was using useCustomCountFn to work around the collation/session bug.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCustomCountFnFixes included in 1.9.4:
.collation()oncountDocumentswas breaking session contextcountDocuments, causing incorrecttotalDocscountTest plan
pnpm test:int database- all 160 tests passensure mongodb respects collation when using collection in the configensure mongodb collation works with draft pagination without sortAdditional context #15990