chore: replace localhost:3000 with stable portless URLs for development#16063
Open
chore: replace localhost:3000 with stable portless URLs for development#16063
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
AlessioGr
commented
Mar 27, 2026
| return new Response(response.body, { | ||
| headers: { | ||
| 'Content-Disposition': `attachment; filename="${asciiFileName}"; filename*=UTF-8''${encodedFileName}`, | ||
| 'Content-Length': response.headers.get('content-length') || '', |
Member
Author
There was a problem hiding this comment.
Valid bug this PR exposed. 'Content-Length': '' is invalid - the || '' fallback sends an empty string. Works without portless because Next.js serves the response directly, but any HTTP proxy (including portless) rejects this with HPE_INVALID_CONTENT_LENGTH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously every dev server and test run used
localhost:3000, which caused constant port conflicts when running other apps locally, and was especially painful for AI agents that had to discover and manage ports. Hardcodedlocalhost:3000port references were scattered across multiple test files with no single source of truth.This adds portless as a dev dependency and wraps all dev scripts with it. Every dev server now gets a stable URL at
http://payload-monorepo.localhost:1355regardless of what else is running - portless handles port assignment automatically behind the scenes. A sharedserverURLhelper (test/__helpers/shared/serverURL.ts) replaces all the hardcodedlocalhost:3000references so there's exactly one place to change if the URL ever needs updating (e.g. we might want to use https by default in the future - currently https is too glitchy).Everything works on fresh clones with just
pnpm installsince portless is a devDependency and the proxy auto-starts. To bypass portless entirely, set PORTLESS=0Examples
Example: You're working on both the payload monorepo and the Payload website that also runs a Next.js dev server. Without portless, both default to port 3000 - you have to stop one before starting the other, or manually remember that one project is using a different port:
Will you reliably remember which url belongs to which project at this very moment? No? The agent also will not. Then suddenly you exit project A, restart project B, and the port changes. You get confused? The agent will too.
With portless, the monorepo is always at
http://payload-monorepo.localhost:1355and you can give the other project its own name, so they coexist without conflict and you never have to think about ports.changes into