fix(plugin-multi-tenant): infinite api calling loop on user switch#16065
Open
fix(plugin-multi-tenant): infinite api calling loop on user switch#16065
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, using the
multi-tenantexample you were able to reproduce the following:super-admindemo@payloadcms.comdemotenant1tenant1@payloadcms.comdemotenant2tenant2@payloadcms.comdemoYou'd see an infinite spam of requests to
/tenants/populate-tenant-optionsbecause ofuseEffectinTenantSelectionProvider/index.client.tsxWhy?
Login as Tenant 2 → userChanged=true → syncTenants() fetches data
→ setTenantOptions(new array) → tenantOptions reference changes
→ effect re-runs (tenantOptions in deps) → stale initialValue ≠ cookie
→ syncTenants() again → new array reference again → ∞
This PR makes the
setTenantOptionscall stable (avoid a new reference when not changed) and removestenantOptionsfrom the dependency array (the tenant options selector still updates correctly when logging out / logging in as a different user)