fix: delete current session on logout instead of only expiring the cookie#16079
Open
moktamd wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: delete current session on logout instead of only expiring the cookie#16079moktamd wants to merge 1 commit intopayloadcms:mainfrom
moktamd wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…okie The logout operation skipped session deletion when disableLocalStrategy was true, causing sessions to accumulate in the users_sessions table. For single-session logout, use the existing revokeSession helper instead of reimplementing session filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16061
The logout operation guarded session deletion behind
disableLocalStrategy !== true, which meant sessions were never cleaned up when using external auth strategies with sessions enabled. Even with the local strategy, the inline session filtering reimplemented logic that already existed inrevokeSession.Changes:
disableLocalStrategygate so sessions are cleaned regardless of auth strategyrevokeSessionhelper for single-session logout instead of reimplementing the filteringallSessionspath for clearing all sessions at once