removing bad configure guidance and adding note regarding billing#339
Open
jrtuenge wants to merge 2 commits intopbugnion:masterfrom
Open
removing bad configure guidance and adding note regarding billing#339jrtuenge wants to merge 2 commits intopbugnion:masterfrom
jrtuenge wants to merge 2 commits intopbugnion:masterfrom
Conversation
…t should be on documentation page
Owner
|
This is great, thank you! I wonder if it would be a good idea to move your sentence that says "If you get a "this page can't load Google maps correctly" error,..." to the documentation on authentication rather than the README? |
Owner
|
I guess that's what you mean by "which should probably be moved to documentation to consolidate and harmonize"? If so, then I agree. |
Author
|
Correct!
…On Tue, May 26, 2020 at 11:09 PM Pascal Bugnion ***@***.***> wrote:
I guess that's what you mean by "which should probably be moved to
documentation to consolidate and harmonize"?
If so, then I agree.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#339 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPP4IEDPUPFLDRVWOYPZSLRTSVDBANCNFSM4NKP67MQ>
.
|
Owner
|
Just to clarify, were you planning on doing that? If so, the source is in Alternatively, I can do it in the near future, but I probably won't merge this PR till then. |
Author
|
I just made the edit and pushed to my fork, but without creating a new
branch... I'm a bit of a novice with git, so am not sure how best to
proceed. The screenshot below shows what I see after trying to issue a new
PR. What would you suggest I do? I'd be fine reforking and recloning, if
that'd help.
[image: Screen Shot 2020-05-31 at 10.02.57 AM.png]
…On Sun, May 31, 2020 at 8:13 AM Pascal Bugnion ***@***.***> wrote:
Just to clarify, were you planning on doing that? If so, the source is in
docs/source/authentication.rst.
Alternatively, I can do it in the near future, but I probably won't merge
this PR till then.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#339 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPP4IAIQEHQR5F2IC7K5GLRUJXX3ANCNFSM4NKP67MQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed bad configure guidance (which should also be removed from documentation), and added note regarding billing (which should probably be moved to documentation to consolidate and harmonize).