Fix FNO inverse pipeline for InitialConditionInterp with multi-step inputs#101
Open
Mattia-PCS wants to merge 1 commit into
Open
Fix FNO inverse pipeline for InitialConditionInterp with multi-step inputs#101Mattia-PCS wants to merge 1 commit into
Mattia-PCS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the FNO inverse pipeline when using
InitialConditionInterpwithinitial_step > 1.Two related issues were identified:
inverse_loader, preventing correct model initialization.InitialConditionInterpreconstructed only a single initial time slice, while FNO checkpoints trained withinitial_step > 1expect the full initial temporal window.Changes
inverse_loaderin the FNO branchValidation
The original code raises:
After fixing the loader initialization, the next failure is:
With this patch, the same command completes successfully:
The resulting input matches the FNO forward pipeline:
Fixes #ISSUE_NUMBER