Skip to content

fix(csharp-ci): pin Record-shard-result to workspace for non-root working-directory callers #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monsieurleberre merged 2 commits into from
Jun 19, 2026
Merged

fix(csharp-ci): pin Record-shard-result to workspace for non-root working-directory callers #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
791b2e4
fix(csharp-ci): pin Record-shard-result to workspace so non-root work…
monsieurleberre Jun 19, 2026
7900aa0
docs(changelog): cut 2.3.1 section for shard-result fix
monsieurleberre Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/csharp-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ jobs:

- name: Record shard result
if: ${{ !cancelled() }}
working-directory: ${{ github.workspace }}
env:
SHARD_NAME: ${{ matrix.name }}
SHARD_STATUS: ${{ job.status }}
Expand Down
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [2.3.1] - 2026-06-19

### Fixed

- Fix `csharp-ci.yaml` failing the `Upload shard result` step for callers that pass a non-root `working-directory` (e.g. `working-directory: csharp`). The `Record shard result` step inherited the job's `defaults.run.working-directory` and wrote `ci-result/<name>.txt` under that subdirectory, but `actions/upload-artifact` ignores `defaults.run.working-directory` and resolves its `path:` relative to the repo root, so the upload failed with `No files were found with the provided path: ci-result/<name>.txt` (`if-no-files-found: error`). The `Record shard result` step is now pinned to `working-directory: ${{ github.workspace }}` so it writes at the repo root, matching where `upload-artifact` reads — mirroring how the adjacent coverage steps are already pinned. Reported by `peacefulstudio/canton-localnet-internal`. (#28)

## [2.3.0] - 2026-06-18

### Added
Expand Down Expand Up @@ -101,7 +107,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `csharp-ci.yaml` — .NET build / test / coverage / pack.
- `terraform-ci.yaml` — Terraform fmt / validate / test.

[Unreleased]: https://github.com/peacefulstudio/github-actions/compare/v2.3.0...HEAD
[Unreleased]: https://github.com/peacefulstudio/github-actions/compare/v2.3.1...HEAD
[2.3.1]: https://github.com/peacefulstudio/github-actions/compare/v2.3.0...v2.3.1
[2.3.0]: https://github.com/peacefulstudio/github-actions/compare/v2.2.0...v2.3.0
[2.2.0]: https://github.com/peacefulstudio/github-actions/compare/v2.1.0...v2.2.0
[2.1.0]: https://github.com/peacefulstudio/github-actions/compare/v2.0.0...v2.1.0
Expand Down