Skip to content

fix(go-ci): take coverage report ownership without sudo #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monsieurleberre merged 1 commit into from
Jun 23, 2026
Merged

fix(go-ci): take coverage report ownership without sudo #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/go-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,15 @@ jobs:
echo "::error::CodeCoverageSummary did not produce code-coverage-results.md"
exit 1
fi
# Workaround: CodeCoverageSummary runs inside a Docker container
# that writes code-coverage-results.md as root, so chown it back
# before editing.
sudo chown "$(id -un)" code-coverage-results.md
# Workaround: irongut/CodeCoverageSummary runs inside a Docker
# container that may write code-coverage-results.md as root. Self-hosted
# runners lack passwordless sudo, so take ownership without sudo by
# replacing the file with a runner-owned copy when it is not already
# writable (a same-directory rename only needs workspace dir perms).
if [ ! -w code-coverage-results.md ]; then
cp code-coverage-results.md code-coverage-results.md.owned
mv -f code-coverage-results.md.owned code-coverage-results.md
fi
go install github.com/fzipp/gocyclo/cmd/gocyclo@v0.6.0
GOCYCLO="$(go env GOPATH)/bin/gocyclo"

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fix `go-ci.yaml` failing the `Augment coverage report with cyclomatic complexity` step on self-hosted runners. The step ran `sudo chown "$(id -un)" code-coverage-results.md` to take back a file that `irongut/CodeCoverageSummary` (a Docker action) writes as root, but self-hosted runners (e.g. the Hetzner pool) lack passwordless sudo, so the step died with `sudo: a password is required` — breaking every Go consumer's `build-and-test` job once it compiled far enough to reach coverage. Ownership is now taken without sudo: when the report is not writable it is replaced with a runner-owned copy via a same-directory `cp` + `mv -f`, which needs only workspace-directory permissions and is a no-op on GitHub-hosted runners where the file is already writable. Reported by `peacefulstudio/terraform-provider-canton-internal`.

## [2.3.1] - 2026-06-19

### Fixed
Expand Down