feat: implement dark mode toggle#2
Open
phsbrown wants to merge 2 commits into
Open
Conversation
- Add ThemeService for theme state management - Add ThemeToggle component with sun/moon icons - Use Bootstrap's built-in dark mode via data-bs-theme attribute - Persist theme preference in localStorage
5 tasks
Collaborator
Author
Code Review (Opus 4.6 / Codex 5.3)Issues Found:1. [HIGH] Theme icon doesn't update after toggle
2. [MEDIUM] Duplicate theme initialization
3. [MEDIUM] Missing error handling for JS interop
4. [LOW] Missing accessibility attribute
|
Collaborator
Author
Implementation CompleteFixed all issues:
Changes made to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Descrição
Implementa funcionalidade de Dark Mode no aplicativo Blazor utilizando o suporte nativo do Bootstrap 5.3+.
📦 Alterações
Novos arquivos
Alterações existentes
🎨 Como funciona
✅ Tasks da issue #1