Skip to content

Fix navigation groups#2455

Open
Boy132 wants to merge 1 commit into
mainfrom
boy132/fix-navigation-groups
Open

Fix navigation groups#2455
Boy132 wants to merge 1 commit into
mainfrom
boy132/fix-navigation-groups

Conversation

@Boy132

@Boy132 Boy132 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Apparently #1850 broke our navigation group checks and no one even noticed :D

@Boy132 Boy132 self-assigned this Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83cf2b3a-3149-40d9-aa76-6ea85ee0def2

📥 Commits

Reviewing files that changed from the base of the PR and between 1f2ff09 and 30c647b.

📒 Files selected for processing (5)
  • app/Filament/Admin/Resources/Eggs/EggResource.php
  • app/Filament/Admin/Resources/Nodes/NodeResource.php
  • app/Filament/Admin/Resources/Roles/RoleResource.php
  • app/Filament/Admin/Resources/Servers/ServerResource.php
  • app/Filament/Admin/Resources/Users/UserResource.php

📝 Walkthrough

Walkthrough

This PR updates the getNavigationGroup() method across five Filament admin resource classes (EggResource, NodeResource, RoleResource, ServerResource, UserResource) to use strict equality checks against the string 'topbar' for the TopNavigation customization value, replacing previous loose truthy checks.

Changes

Navigation Group Condition Tightening

Layer / File(s) Summary
Strict topbar equality check
app/Filament/Admin/Resources/Eggs/EggResource.php, app/Filament/Admin/Resources/Nodes/NodeResource.php, app/Filament/Admin/Resources/Roles/RoleResource.php, app/Filament/Admin/Resources/Servers/ServerResource.php, app/Filament/Admin/Resources/Users/UserResource.php
Each getNavigationGroup() method now compares user()?->getCustomization(CustomizationKey::TopNavigation) strictly against 'topbar' instead of relying on a truthy check, changing which navigation group label or null is returned.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: tightening the navigation group logic.
Description check ✅ Passed The description is directly related to the navigation group regression being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants