make SPIFFS_write() data parameter const#109
Open
benpicco wants to merge 1 commit intopellepl:masterfrom
Open
Conversation
SPIFFS_write() doesn't change the source data, so mark it as const. This fixes a warning when SPIFFS_write() is used on read-only data.
Contributor
Author
|
Only now did I realize that there is already a pull request for this #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIFFS_write() doesn't change the source data, so mark it as const.
This fixes a warning when SPIFFS_write() is used on read-only data (and probably allows some compiler optimizations).
changes
s32_t SPIFFS_write(spiffs *fs, spiffs_file fh, void *buf, s32_t len);->s32_t SPIFFS_write(spiffs *fs, spiffs_file fh, const void *buf, s32_t len);