fix: validate cache page index in spiffs_cache_page_free#304
Open
Eun0us wants to merge 1 commit intopellepl:masterfrom
Open
fix: validate cache page index in spiffs_cache_page_free#304Eun0us wants to merge 1 commit intopellepl:masterfrom
Eun0us wants to merge 1 commit intopellepl:masterfrom
Conversation
…free When a SPIFFS filesystem image is malformed, cp->ix can contain an invalid value (e.g. negative). This leads to undefined behavior in the expression `1 << ix` when ix is negative or >= 32. Add a bounds check at the start of spiffs_cache_page_free() to return SPIFFS_ERR_INTERNAL for out-of-range indices. Found via https://github.com/Eun0us/esp-fuzzer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a SPIFFS filesystem image is malformed,
cp->ixcan contain an invalid value (e.g. negative). This leads to undefined behavior in the expression1 << ixwhenixis negative or >= 32 (C standard §6.5.7).This adds a bounds check at the start of
spiffs_cache_page_free()to returnSPIFFS_ERR_INTERNALfor out-of-range indices, preventing the UB shift.How it was found
Found via fuzzing with esp-fuzzer and
-fsanitize=undefined:Test plan