Fix account page#108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 11 11
Lines 541 541
=======================================
Hits 526 526
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| Confirm | ||
| </Button> | ||
| <Button type="button" cancel onClick={onCancel}> | ||
| X |
There was a problem hiding this comment.
Swap this out with feather icon
| <Button margin="1.5rem 0 0 0">Save</Button> | ||
| <Button | ||
| margin="1.5rem 0 0 0" | ||
| style={{ fontSize: "1.2rem" }} |
There was a problem hiding this comment.
Probably a better idea to move this to the styled component prop
There was a problem hiding this comment.
Actually, any reason for bumping the font size? I think the font size is a little too big here - and it seems like the text isn't aligned
| font-size: 1.5rem; | ||
| `; | ||
|
|
||
| export const FormGroupGrid = styled.div` |
There was a problem hiding this comment.
This should definitely be more generalized instead of hardcoding the numbers - perhaps a marginBottom prop with type string with default of 0?
| height: 1rem; | ||
| margin-top: 0.35rem; | ||
| background-color: #e7e7e7; | ||
| ${({ blue }) => `background-color: ${blue ? "#adcced" : "#e7e7e7"};`} |
There was a problem hiding this comment.
Same as above - perhaps better to have a color props
| margin?: string; | ||
| cancel?: boolean; | ||
| }>` | ||
| background-color: ${(props) => (props.cancel ? "#93a0ad" : "#209cee")}; |
2 participants
Multiple fixes for account page frontend