Merged
Conversation
detectPointOperationとextractTargetFromTextが独立して動作していたため、 複数の絵文字パターンが含まれるテキストでターゲットとオペレーターの対応が ずれる問題があった。detectOperationAndTarget関数に統合し、1つの正規表現で ターゲット抽出とオペレーション検出を同時に行うよう修正。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectPointOperationとextractTargetFromTextが独立していたため、:emoji:テキスト ++のようにターゲットとオペレーターの間に文字が入った場合に誤検出する可能性があったdetectOperationAndTarget関数に統合し、1つの正規表現でターゲット抽出とオペレーション検出を同時に実行するよう修正extractUserID,extractEmojiName,extractTargetFromTextを削除Test plan
:haruotsu-no1:hogehogehogege ++で反応しないことを確認:haruotsu-no1:hogehogehogege --で反応しないことを確認:sake:hogehoge++で反応しないことを確認:sake: ++/:sake:++で正常に反応することを確認<@U123456> ++で正常に反応することを確認hello :foo:bar :baz: ++）で正しいターゲット（:baz:）が選ばれることを確認go test ./...)