環境によるcontext_matchesのスイッチと、Tazuna YAMLのGo Template化#64
Merged
Conversation
Signed-off-by: drumato <drumato@pepabo.com>
Signed-off-by: drumato <drumato@pepabo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概要
-e/--environmentを利用した環境差分の表現を実現します。これにより、
context_matchesをさらに厳格に運用し、クラスタごとのバリデーションを細かく実施できます。これをさらに拡張して、tazuna yamlは Go template として解釈されてレンダリングされたものが利用されるようにします。
これによって、
{{ .Environment }}のような変数をtazuna yamlで利用できます。Changes / 変更点
-eと.spec.environmentsを利用した柔軟なバリデーションの実装Test plan / 動作確認
make testmake lintmake test-integration(if relevant / 関連する場合)make test-e2e(if relevant / 関連する場合)Related issues / 関連 issue