Fix: downtime registration without duration now sets default value and updated docs too#72
Open
yunushaikh wants to merge 1 commit intopercona:masterfrom
Open
Conversation
…d update docs too
kamil-holubicki
force-pushed
the
master
branch
2 times, most recently
from
d301f13 to
3b5b0f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a downtime with API without a duration didn't add the downtime.
So the changes will allow to set default duration when the duration is not passed specifically using the configuration parameter in orchestrator
MaintenanceExpireMinutes.Related issue: https://github.com/openark/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]