PT-2488 - full refactor of a pt-k8s-debug-collector#1054
Open
Conversation
it-percona
temporarily deployed
to
PT-2448-pt-k8s-debug-collector-refactoring - percona-toolkit PR #1054
Render
Destroyed
5 tasks
svetasmirnova
requested changes
Jan 12, 2026
Collaborator
svetasmirnova
left a comment
svetasmirnova
left a comment
There was a problem hiding this comment.
I just started review and underlined few obvious things.
In addition to the comment I think adding tests for new added files, such as logs.go, paths.go, etc. makes sense.
BON4
changed the title
This refactor includes replacing all of the `kubectl` cli calls with golang sdk for k8s. Additionaly dumper now has new structure, new logger, tar file path controll, and multithreaded approach for downloading and exporting files form multiple pods.
BON4
force-pushed
the
PT-2448-pt-k8s-debug-collector-refactoring
branch
from
df8e2ee to
99ad957
Compare
svetasmirnova
requested changes
Feb 26, 2026
Collaborator
svetasmirnova
left a comment
svetasmirnova
left a comment
There was a problem hiding this comment.
Please add back TestPT_2169, replace resource: "pg", with resource: "pgv2",
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
artemgavrilov
approved these changes
Mar 2, 2026
Contributor
artemgavrilov
left a comment
artemgavrilov
left a comment
There was a problem hiding this comment.
@BON4 Please next time write some reply to comments. Even simple done will simplify re-review. With silent resolving reviewer has to do extra work to check if comment was addressed or you don't agree and wouldn't change or something else...
ylacancellera
approved these changes
Mar 4, 2026
svetasmirnova
approved these changes
Mar 5, 2026
imp3142
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor includes replacing all of the
kubectlcli calls with golang sdk for k8s. Additionaly dumper now has new structure, new logger, tar file path controll, and multithreaded approach for downloading and exporting files form multiple pods.Resulting Archive changes
added
cluster-scopedfolder for the resources that are cluster wide.in the root there is a total log file, instead of just errors.
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
(
/libwas not changed)Documentation updated
Test suite update