Skip to content

Fix event property handling and improve value assignment #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kedarvj wants to merge 1 commit into from
Closed

Fix event property handling and improve value assignment #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bin/pt-query-digest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5234,6 +5234,10 @@ sub parse_event {
}

PTDEBUG && _d('Properties of event:', Dumper(\@properties));
if ( @properties % 2 ) {
PTDEBUG && _d('Skipping malformed event (odd properties):', Dumper(\@properties));
next EVENT;
}
my $event = { @properties };
if ( !$event->{arg} ) {
PTDEBUG && _d('Partial event, no arg');
Expand Down Expand Up @@ -5625,6 +5629,10 @@ sub make_handler {
);
}

if ( $type =~ m/^(?:num|bool)$/ ) {
push @lines, q{$val = 0 if defined $val && $val eq '';};
}

if ( $type eq 'num' && $self->{attrib_limit} ) {
push @lines, (
"if ( \$val > $self->{attrib_limit} ) {",
Expand Down Expand Up @@ -5654,7 +5662,7 @@ sub make_handler {
. $gt . ' PLACE->{max};',
);
if ( $track{sum} ) {
push @tmp, 'PLACE->{sum} += $val;';
push @tmp, 'PLACE->{sum} += (defined $val && $val ne q{} ? $val : 0);';
}

if ( $track{all} ) {
Expand Down
Loading